Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : Bug in Phrases.export_phrases() #879

Merged
merged 2 commits into from
Sep 25, 2016
Merged

Fix : Bug in Phrases.export_phrases() #879

merged 2 commits into from
Sep 25, 2016

Conversation

AadityaJ
Copy link
Contributor

Refer to the Issue : #794

@tmylk
Copy link
Contributor

tmylk commented Sep 25, 2016

Thanks for the PR! Please add a note in CHANGELOG.

Also please add a new test that test specifically for this issue.

tmylk
tmylk suggested changes Sep 25, 2016
View reviewed changes
Copy link
Contributor

@tmylk tmylk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new test that test specifically for this issue

@AadityaJ
Copy link
Contributor Author

Added test cases and edited CHANGELOG.

@tmylk tmylk merged commit 6238481 into piskvorky:develop Sep 25, 2016
@gojomo gojomo mentioned this pull request Sep 26, 2016
Closed
@toumorokoshi toumorokoshi mentioned this pull request May 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmylk tmylk tmylk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AadityaJ @tmylk